-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix: data-disabled CSS selector for DateField #7896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: data-disabled CSS selector for DateField #7896
Conversation
…://github.com/suyash5053/react-spectrum into 7890-fix-data-disabled-selector-for-DateField
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, would you be willing to add some tests such as https://github.com/adobe/react-spectrum/blob/main/packages/react-aria-components/test/DateField.test.js#L166 ?
@snowystinger Yeah Sure, I was waiting to see whether I'm on the right track or not. Will write the test cases :). |
Hey @snowystinger, I have added some test cases, feel free to suggest me some more if needed. A different question is, in TimeField we also see the disabled state but there are no test cases related to them. Is this an issue or we just left them knowingly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests, I left some comments
Please direct me with a specific test case and approach that I should have, if I'm not understanding something. @snowystinger |
I’d like to add a few considerations, as this PR caught my attention. Currently, for In addition, data props such as |
@Persists is this making it difficult to implement something?
Otherwise, it can be useful, particularly when using utility based CSS, to not make selectors that reference parents. |
@yihuiliao Thank you! @snowystinger Thanks! That makes sense. |
Closes #7890
✅ Pull Request Checklist: